> 1 <
| Author | Message |
Kort |
#268 2008-03-20 07:55 GMT |
|
General impression: great job
Suggestions: rather than displaying just 2 links (worst / best) in the main plug screen is better to output the two tables Some remarks / cleanups: karma.php ================= line 52 Code: $plugin_body .= "<table class=\"cells\">"; Table width already defined by the cells classline 54-56 Code: $plugin_body .= "<td class=\"coltop\">".$L['Name']."</td>"; No need to override coltop class here$plugin_body .= "<td class=\"coltop\">".$L['Value']."</td>"; $plugin_body .= "<td class=\"coltop\">".$L['Status']."</td>"; line 60 Code: $plugin_body .= "<tr><td class=\"centerall\">".sed_build_user($row['user_id'], $row['user_name'])."</td>"; Single & double quotes mixed up in the plug code$plugin_body .= "<td class=\"centerall\"><a href=\"plug.php?e=karma&act=show&fp=\"".$row['user_id'].">".$row['karma_sum']."</a></td>"; line 206 Code: $plugin_body .= "<table class=\"cells\">\n"; Apply cells class to look uniformline 208-212 Code: $plugin_body .= "<td class=\"coltop\">".$L['Name']."</td>"; No need to override coltop class here$plugin_body .= "<td class=\"coltop\">".$L['Value']."</td>"; $plugin_body .= "<td class=\"coltop\">".$L['Comment']."</td>"; $plugin_body .= "<td class=\"coltop\">".$L['Reason']."</td>"; $plugin_body .= ($moderate) ? "<td class=\"coltop\">".$L['Delete']."</td>" : ""; line 219-223 Code: $plugin_body .= "<td class=\"centerall\"><a href=\"users.php?m=details&id=".$row['user_id']."\" target=_blank>".$row['user_name']."</td>"; align=\"center\" valign=\"middle\" is actually the centerall class that exists in every sed skin$plugin_body .= "<td class=\"centerall\">".$row['karma_value']."</td>"; $plugin_body .= "<td width=\"100%\">".sed_parse($row['karma_text'], $cfg['parsebbcodeforums'], $cfg['parsesmiliesforums'], 1)."</td>"; $plugin_body .= "<td class=\"centerall\"><a href=\"forums.php?m=posts&p=".$row['karma_fp']."#".$row['karma_fp']."\" target=_blank>".$L['View']."</a></td>"; $plugin_body .= ($moderate) ? "<td class=\"centerall\"><a href=\"plug.php?e=karma&act=moderate&fp=".$row['karma_id']."\">".$L['Delete']."</a></td>" : ""; karma.forums.posts.loop.php ================================ line 69, 70 Code: class=\"btn\" btn class not mentioned in the readme.txtCode: plugins/karma/img/rep_plus.gif points to the gifs placed in the plugins dir, not in the Code: skins/$skin/img/system as indicated in the readme.txt
|
|
Trustmaster
48 posts
http://www.politehnik.info Location: Russia Nizhny Novgorod Occupation: University Student, Engineer/Programmer, IT Expert Age: 20 |
#270 2008-03-21 10:48 GMT |
|
Good idea about plugin main page. As for class mistakes, these are from original LDU karma, I just copy&pasted them. But I'll fix it in 1.5.
|
|
|
May the Source be with you!
Open source development, commercial support, consulting and outsourcing. Send  for details. |
|
gofgo
1 posts
Location: Croatia Occupation: Age: |
#271 2008-03-30 16:52 GMT |
|
When somone "karms" user who posted post with picture its not looking very good in that small window ;)
Preview login user:Test pw:test |
|
Kort |
#272 2008-03-31 18:16 GMT |
|
Some suggestions regarding plugins\karma\karma.forums.posts.loop.php:
Code: if(sed_auth('plug', 'karma', 'W')) And add some descriptors to the skin css-file:{ $t-> assign(array( "FORUMS_POSTS_ROW_KARMA_ADD" => "<a href=\"plug.php?e=karma&act=change&value=add&fp=".$row['fp_id']."\"><img src=\"skins/$skin/img/plugins/karma/plus.gif\" class=\"plus\" alt=\"[+]\" /></a>", "FORUMS_POSTS_ROW_KARMA_DEL" => "<a href=\"plug.php?e=karma&act=change&value=del&fp=".$row['fp_id']."\"><img src=\"skins/$skin/img/plugins/karma/minus.gif\" class=\"minus\" alt=\"[-]\" /></a>", )); } Code: .karma { margin:10px 0; }
.karma span { background:#fff; border:1px solid #999; padding:2px 5px; } .karma img { vertical-align:-1px; } .karma img.plus { margin-right:5px; } .karma img.minus { margin-left:5px; } |
|
> 1 <